Skip to content

Reverse the meaning of is_argument when used for type check#7039

Merged
ilevkivskyi merged 1 commit into
python:masterfrom
nnja:update_var_names_for_fix_classvar_as_string_failing
May 23, 2018
Merged

Reverse the meaning of is_argument when used for type check#7039
ilevkivskyi merged 1 commit into
python:masterfrom
nnja:update_var_names_for_fix_classvar_as_string_failing

Conversation

@nnja

@nnja nnja commented May 22, 2018

Copy link
Copy Markdown
Contributor

Reverse the meaning of is_argument added in #6824, per this review: #6824 (review)

@nnja nnja mentioned this pull request May 22, 2018
Merged
ilevkivskyi
ilevkivskyi approved these changes May 22, 2018
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks like Travis failure is unrelated. I will try restarting the tests.

@asvetlov

asvetlov commented May 22, 2018

Copy link
Copy Markdown
Contributor

Sorry, looks like we still have flaky asyncio tests.
I've fixed some problems but subprocess tests still unstable. Working on it.

@nnja

nnja commented May 23, 2018

Copy link
Copy Markdown
Contributor Author

Thanks @asvetlov. @ilevkivskyi -- looks like the tests are all green ✅now.

@ilevkivskyi ilevkivskyi merged commit 0e61dff into python:master May 23, 2018
@miss-islington

miss-islington commented May 23, 2018

Copy link
Copy Markdown
Contributor

Thanks @nnja for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

bedevere-bot commented May 23, 2018

Copy link
Copy Markdown

GH-7066 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2018
@nnja @miss-islington
Reverse the meaning of is_argument when used for type check (pythonGH…
4485102 
…-7039)

(cherry picked from commit 0e61dff)

Co-authored-by: Nina Zakharenko <nzakharenko@gmail.com>
miss-islington added a commit that referenced this pull request May 23, 2018
@miss-islington @nnja
Reverse the meaning of is_argument when used for type check (GH-7039)
0f9b68a 
(cherry picked from commit 0e61dff)

Co-authored-by: Nina Zakharenko <nzakharenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nnja @asvetlov @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni